Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[newrelic-pixie] Include helm .Release.Revision in job fullname #1273

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

techdragon
Copy link

Is this a new chart

  • No

What this PR does / why we need it:

  • This helm chart does not allow clean updates, by not having a unique job name, any helm updates on the chart such as to change excluded namespaces or any other chart setting, results in a failure due to editing an immutable field that helm cant update. Requiring the deletion of the job before any deployment of this chart. By adding the revision into the job name this failure can be avoided.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])

@nserrino @philkuz @htroisi @juanjjaramillo @svetlanabrennan @nrepai @csongnr @vuqtran88 @xqi-nr

This should resolve the closed and unresolved newrelic#1112 which I have an open support case with New Relic about.
@CLAassistant
Copy link

CLAassistant commented Feb 8, 2024

CLA assistant check
All committers have signed the CLA.

@techdragon
Copy link
Author

CLA signed.

@techdragon techdragon requested a review from a team as a code owner October 14, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants